Ngone51 commented on a change in pull request #27604: [SPARK-30849][CORE][SHUFFLE]Fix application failed due to failed to get MapStatuses broadcast block URL: https://github.com/apache/spark/pull/27604#discussion_r382410631
########## File path: core/src/main/scala/org/apache/spark/broadcast/TorrentBroadcast.scala ########## @@ -186,7 +186,7 @@ private[spark] class TorrentBroadcast[T: ClassTag](obj: T, id: Long) } blocks(pid) = new ByteBufferBlockData(b, true) case None => - throw new SparkException(s"Failed to get $pieceId of $broadcastId") Review comment: Why not just catch `SparkException` outside? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org