Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4688#discussion_r25525865
  
    --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
    @@ -313,6 +320,21 @@ private[spark] class Client(
         env("SPARK_YARN_MODE") = "true"
         env("SPARK_YARN_STAGING_DIR") = stagingDir
         env("SPARK_USER") = 
UserGroupInformation.getCurrentUser().getShortUserName()
    +    // If we logged in from keytab, make sure we copy the keytab to the 
staging directory on
    +    // HDFS, and setup the relevant environment vars, so the AM can login 
again.
    +    if (loginFromKeytab) {
    +      val fs = FileSystem.get(hadoopConf)
    +      val stagingDirPath = new Path(fs.getHomeDirectory, stagingDir)
    +      val localUri = new URI(args.keytab)
    +      val localPath = getQualifiedLocalPath(localUri, hadoopConf)
    +      val destinationPath = new Path(stagingDirPath, keytabFileName)
    +      val replication = 
sparkConf.getInt("spark.yarn.submit.file.replication",
    --- End diff --
    
    we already get this in spark.yarn.submit.file.replication, would be nice to 
only get it once and reuse.
    
    Seems like this would belong in prepareLocalResources, just change 
description of it slightly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to