Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4688#discussion_r25526204
  
    --- Diff: 
yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala ---
    @@ -256,6 +256,12 @@ private[spark] class ApplicationMaster(
     
       private def runDriver(securityMgr: SecurityManager): Unit = {
         addAmIpFilter()
    +
    +    // This must be done before SparkContext is initialized, since the 
CoarseGrainedSchedulerBackend
    +    // is started at that time. That is what schedules the re-logins. It 
is scheduled only if the
    +    // principal is actually setup. So we make sure it is available.
    +    SparkHadoopUtil.get.setPrincipalAndKeytabForLogin(
    +      System.getenv("SPARK_PRINCIPAL"), System.getenv("SPARK_KEYTAB"))
    --- End diff --
    
    yeah we should use configs whenever possible.  env variables are mostly old 
and haven't been cleaned up yet.
    
    Configs also give you the option of setting these things in your spark conf 
file rather then having to pass them in every time.   Make sure to name them 
something obvious and yarn specific.
    
    History server keytab configs: 
http://spark.apache.org/docs/1.1.0/monitoring.html


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to