Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4818#discussion_r25544599
  
    --- Diff: 
yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala ---
    @@ -290,8 +290,18 @@ private[yarn] class YarnAllocator(
           location: String,
           containersToUse: ArrayBuffer[Container],
           remaining: ArrayBuffer[Container]): Unit = {
    +    // SPARK-6050: certain Yarn configurations return a resource 
configuration that doesn't match
    +    // the request; for example, capacity scheduler + 
DefaultResourceCalculator. Allow users in
    +    // those situations to disable resource matching.
    +    val matchingResource =
    +        if (sparkConf.getBoolean("spark.yarn.container.matchAnyResource", 
false)) {
    --- End diff --
    
    Take a look at the latest version to see if it's any clearer.
    
    But the gist is that `amClient.getMatchingResources()` is matching the 
resources you asked for (which is `resource`) against the parameter you're 
passing. What the option controls is whether you're passing `resource` also as 
the resource to match against - so basically, the exact same structure that is 
already in the outstanding list of requests.
    
    So I think you're reading the condition backwards. Or something.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to