Github user sryza commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4818#discussion_r25555091
  
    --- Diff: 
yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala ---
    @@ -290,8 +290,19 @@ private[yarn] class YarnAllocator(
           location: String,
           containersToUse: ArrayBuffer[Container],
           remaining: ArrayBuffer[Container]): Unit = {
    +    // SPARK-6050: certain Yarn configurations return a virtual core count 
that doesn't match the
    +    // request; for example, capacity scheduler + 
DefaultResourceCalculator. Allow users in those
    +    // situations to disable matching of the core count.
    +    val matchingResource =
    +      if (sparkConf.getBoolean("spark.yarn.container.disableCpuMatching", 
false)) {
    +        Resource.newInstance(allocatedContainer.getResource().getMemory(),
    --- End diff --
    
    Actually, why not just use `allocatedContainer.getResource`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to