Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/4021#issuecomment-76512378
Another thought: if `register()` is somehow called twice for the same
accumulator, then it looks like we'll silently overwrite the existing value in
`localAccums`. We should probably throw an exception instead, since that
scenario could lead to lost updates.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
