Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4021#discussion_r25560891
--- Diff: core/src/main/scala/org/apache/spark/Accumulators.scala ---
@@ -307,11 +310,22 @@ private[spark] object Accumulators {
}
}
+ def remove(accId : Long) {
+ synchronized {
+ originals.remove(accId)
+ }
+ }
+
// Get the values of the local accumulators for the current thread (by
ID)
def values: Map[Long, Any] = synchronized {
val ret = Map[Long, Any]()
for ((id, accum) <- localAccums.get) {
- ret(id) = accum.localValue
+ // Since we are now storing weak references, we must check whether
the underlying data
+ // is valid.
+ ret(id) = accum.get match {
+ case Some(values) => values.localValue
+ case None => None
--- End diff --
This was dumb for me to overlook, too: if the data structure is invalid,
then this would just silently ignore it; even if this was a rare
error-condition, there should have been a warning here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
