Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4823#discussion_r25558245
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
@@ -42,6 +42,18 @@ private[ui] class AllJobsPage(parent: JobsTab) extends
WebUIPage("") {
}
def makeRow(job: JobUIData): Seq[Node] = {
+ // scalastyle:off
+ val killLink = if (killEnabled) {
+ val killLinkUri = "%s/jobs/job/kill?id=%s&terminate=true"
--- End diff --
Just a few tiny comments to consider, if you have to otherwise make changes
to this PR: this might be easier to read with string interpolation
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
