Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4823#discussion_r25558253
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobsTab.scala ---
@@ -29,4 +31,18 @@ private[ui] class JobsTab(parent: SparkUI) extends
SparkUITab(parent, "jobs") {
attachPage(new AllJobsPage(this))
attachPage(new JobPage(this))
+
+ def handleKillRequest(request: HttpServletRequest) = {
--- End diff --
Nit: extra space before brace, and extra parens around `killEnabled`.
Also I slightly wonder about
`Option(request.getParameter("id")).getOrElse("-1").toInt` -- I doubt there
would ever be a negative job ID but seems avoidable by just checking whether
the param exists rather than filling in -1 for missing params. Still I don't
think this does any harm at the moment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
