dongjoon-hyun commented on a change in pull request #27864: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned URL: https://github.com/apache/spark/pull/27864#discussion_r392371891
########## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ########## @@ -1761,6 +1776,57 @@ private[spark] class BlockManager( blocksToRemove.size } + def decommissionBlockManager(): Unit = { + if (!blockManagerDecommissioning) { Review comment: Shall we have a `logDebug` when it's already decommissioning (`blockManagerDecommissioning = true`)? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org