dongjoon-hyun commented on a change in pull request #27864: [SPARK-20732][CORE]
Decommission cache blocks to other executors when an executor is decommissioned
URL: https://github.com/apache/spark/pull/27864#discussion_r392373452
##########
File path:
core/src/main/scala/org/apache/spark/storage/BlockManagerMaster.scala
##########
@@ -43,6 +43,19 @@ class BlockManagerMaster(
logInfo("Removed " + execId + " successfully in removeExecutor")
}
+ /** Decommission block managers corresponding to given set of executors */
+ def decommissionBlockManagers(executorIds: Seq[String]): Unit = {
+ driverEndpoint.ask[Unit](DecommissionBlockManagers(executorIds))
+ }
+
+ /** Get Replication Info for all the RDD blocks stored in given
blockManagerId */
+ def getReplicateInfoForRDDBlocks(
+ blockManagerId: BlockManagerId): Seq[ReplicateBlock] = {
Review comment:
It seems that you don't need to break in this case.
```scala
def getReplicateInfoForRDDBlocks(blockManagerId: BlockManagerId):
Seq[ReplicateBlock] = {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
