cloud-fan commented on a change in pull request #27969:
[SPARK-31170][SQL][test-hive1.2] Spark SQL Cli should respect hive-site.xml and
spark.sql.warehouse.dir
URL: https://github.com/apache/spark/pull/27969#discussion_r397847028
##########
File path:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala
##########
@@ -139,16 +149,6 @@ private[hive] object SparkSQLCLIDriver extends Logging {
// Hive 1.2 + not supported in CLI
throw new RuntimeException("Remote operations not supported")
}
- // Respect the configurations set by --hiveconf from the command line
- // (based on Hive's CliDriver).
- val hiveConfFromCmd =
sessionState.getOverriddenConfigurations.entrySet().asScala
- val newHiveConf = hiveConfFromCmd.map { kv =>
Review comment:
can we try to follow the previous code flow? The new change is hard to
review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
