cloud-fan commented on a change in pull request #27969:
[SPARK-31170][SQL][test-hive1.2] Spark SQL Cli should respect hive-site.xml and
spark.sql.warehouse.dir
URL: https://github.com/apache/spark/pull/27969#discussion_r398483014
##########
File path:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala
##########
@@ -188,8 +190,8 @@ private[hive] object SparkSQLCLIDriver extends Logging {
// Execute -i init files (always in silent mode)
cli.processInitFiles(sessionState)
- newHiveConf.foreach { kv =>
- SparkSQLEnv.sqlContext.setConf(kv._1, kv._2)
+ for ((k, v) <- newHiveConf if k != "hive.metastore.warehouse.dir") {
Review comment:
can we add some comments to explain why we skip
`hive.metastore.warehouse.dir`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
