Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/4828#discussion_r25979785
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala ---
@@ -553,6 +553,7 @@ class StreamingContext private[streaming] (
*/
def stop(stopSparkContext: Boolean = true): Unit = synchronized {
stop(stopSparkContext, false)
+ this.uiTab.foreach(StreamingTab.detachStreamingTab(this, _))
--- End diff --
Why is it hear and not in the other `stop` The tab should be removed when
the stremaing context is stopped, so both `stop` should detach the tab.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
