Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/4828#issuecomment-77648366
Spark core's `UISuite` has an ignored test for "attaching a new tab":
https://github.com/apache/spark/blob/dba0b2eadb441f41ded0f0b9706b720bcfa84881/core/src/test/scala/org/apache/spark/ui/UISuite.scala#L75
In order to test the tab attach / detach functionality, I think we should
re-enable and extend this test to check that we're able to remove the tab that
we just attached. It looks like this test may have been disabled due to port
contention issues (#466), but I think those issues should be resolved now. If
it will be easier, you might rewriting this test using the new
[UISeleniumSuite](https://github.com/apache/spark/blob/dba0b2eadb441f41ded0f0b9706b720bcfa84881/core/src/test/scala/org/apache/spark/ui/UISeleniumSuite.scala)
framework, which will let you use Selenium CSS selectors, etc. in your test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
