Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/4916#issuecomment-77710036 @srowen This change doesn't remove any existing functionality as far as I can see. As @nchammas said if you stopped instances of a certain type you can only get the same type back. Right now we implicitly assumed users would pass the same flag, and this handles the use case where the user doesn't pass the right flag. I had a minor comment inline, but otherwise this change looks good.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org