Github user thvasilo commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4916#discussion_r26021043
  
    --- Diff: ec2/spark_ec2.py ---
    @@ -1259,6 +1259,15 @@ def real_main():
                 cluster_instances=(master_nodes + slave_nodes),
                 cluster_state='ssh-ready'
             )
    +
    +        # Determine types of running instances
    +        existing_master_type = master_nodes[0].instance_type
    +        existing_slave_type = slave_nodes[0].instance_type
    +        if existing_master_type == existing_slave_type:
    --- End diff --
    
    OK, added a comment indicating why we do this, even though the master 
instance type it's not used in this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to