Github user mateiz commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4909#discussion_r26001928
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala 
---
    @@ -467,7 +467,9 @@ private[spark] class Master(
        * two executors on the same worker).
        */
       def canUse(app: ApplicationInfo, worker: WorkerInfo): Boolean = {
    -    worker.memoryFree >= app.desc.memoryPerSlave && 
!worker.hasExecutor(app)
    +    worker.memoryFree >= app.desc.memoryPerSlave &&
    +    !worker.hasExecutor(app) &&
    +    !app.removedExecutors.exists(_.worker == worker)
    --- End diff --
    
    I do think this is a problem for thing like Spark Streaming. Executors 
might fail for many reasons, and this ensures a job will never launch properly. 
A TTL would be nice for that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to