Github user markhamstra commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4909#discussion_r26001955
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala 
---
    @@ -467,7 +467,9 @@ private[spark] class Master(
        * two executors on the same worker).
        */
       def canUse(app: ApplicationInfo, worker: WorkerInfo): Boolean = {
    -    worker.memoryFree >= app.desc.memoryPerSlave && 
!worker.hasExecutor(app)
    +    worker.memoryFree >= app.desc.memoryPerSlave &&
    +    !worker.hasExecutor(app) &&
    +    !app.removedExecutors.exists(_.worker == worker)
    --- End diff --
    
    I agree with @mateiz, and Spark Streaming is by no means the only Spark 
application for which a common use case is to have the entire cluster 
essentially running a single long-lived application.  To have transiently 
failing Executors perpetually banned from doing work for that long-lived 
application is not acceptable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to