[GitHub] [spark] HyukjinKwon commented on a change in pull request #28367: [SPARK-31573][R] apply fixed=TRUE as appropriate to regex usage in R

[GitBox]

HyukjinKwon commented on a change in pull request #28367:
URL: https://github.com/apache/spark/pull/28367#discussion_r415651442



##########
File path: R/pkg/R/sparkR.R
##########
@@ -606,7 +606,7 @@ getClientModeSparkSubmitOpts <- function(submitOps, 
sparkEnvirMap) {
     # process only if --option is not already specified
     if (!is.null(opsValue) &&
         nchar(opsValue) > 1 &&
-        !grepl(sparkConfToSubmitOps[[conf]], submitOps)) {
+        !grepl(sparkConfToSubmitOps[[conf]], submitOps, fixed = TRUE)) {

Review comment:
       This could actually be a bug fix too for very, very unlikely corner 
cases such as `spark.driver.memory` <> `sparkAdriverXmemory`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org