[GitHub] [spark] MichaelChirico commented on a change in pull request #28367: [SPARK-31573][R] Apply fixed=TRUE as appropriate to regex usage in R

[GitBox]

MichaelChirico commented on a change in pull request #28367:
URL: https://github.com/apache/spark/pull/28367#discussion_r415688361



##########
File path: R/pkg/R/sparkR.R
##########
@@ -606,7 +606,7 @@ getClientModeSparkSubmitOpts <- function(submitOps, 
sparkEnvirMap) {
     # process only if --option is not already specified
     if (!is.null(opsValue) &&
         nchar(opsValue) > 1 &&
-        !grepl(sparkConfToSubmitOps[[conf]], submitOps)) {
+        !grepl(sparkConfToSubmitOps[[conf]], submitOps, fixed = TRUE)) {

Review comment:
       yes exactly. there were a few other like this in `utils.R` e.g.
   
   `grep("org.apache.spark.sql.streaming.StreamingQueryException: "`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org