gaborgsomogyi commented on a change in pull request #28368:
URL: https://github.com/apache/spark/pull/28368#discussion_r415756591
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/SecureConnectionProvider.scala
##########
@@ -26,6 +26,12 @@ import org.apache.spark.internal.Logging
import org.apache.spark.sql.execution.datasources.jdbc.JDBCOptions
import org.apache.spark.util.SecurityUtils
+/**
+ * Some of the secure connection providers modify global JVM security
configuration.
+ * In order to avoid race the modification must be synchronized with this.
+ */
+private[connection] object SecurityConfigurationLock
Review comment:
When other parts of the code is also modifying the global JVM security
config then it must be moved into a global place (and must be used).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
