gaborgsomogyi commented on a change in pull request #28368:
URL: https://github.com/apache/spark/pull/28368#discussion_r415758927
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/DB2ConnectionProvider.scala
##########
@@ -48,7 +48,7 @@ private[sql] class DB2ConnectionProvider(driver: Driver,
options: JDBCOptions)
result
}
- override def setAuthenticationConfigIfNeeded(): Unit = {
+ override def setAuthenticationConfigIfNeeded(): Unit =
SecurityConfigurationLock.synchronized {
Review comment:
I've considered to make the sync on the caller side but I think the
suggested solution is better because of the following:
* Not necessarily all the providers modify global JVM security config
* Maybe not the whole `setAuthenticationConfigIfNeeded` function must be
synchronised in later providers, so this way better performing code can be
implemented by synchronising only the absolutely needed parts
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
