maropu commented on a change in pull request #28392:
URL: https://github.com/apache/spark/pull/28392#discussion_r416770553
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/randomExpressions.scala
##########
@@ -102,6 +102,8 @@ case class Rand(child: Expression) extends RDG with
ExpressionWithRandomSeed {
}
override def freshCopy(): Rand = Rand(child)
+
+ override def sql: String = "rand()"
Review comment:
Yea, I also think it's important that we can check seeds, but
`df.explain` is not enough for checking it? Actually, the other two expression
with random seeds (`shuffle` and `uuid`) don't display it in column names;
```
scala> sql("select shuffle(array(1, 2))").show()
+--------------------+
|shuffle(array(1, 2))|
+--------------------+
| [2, 1]|
+--------------------+
scala> sql("select shuffle(array(1, 2))").explain()
== Physical Plan ==
*(1) Project [shuffle([1,2], Some(894779230406706679)) AS shuffle(array(1,
2))#14]
+- *(1) Scan OneRowRelation[]
scala> sql("select uuid()").show()
+--------------------+
| uuid()|
+--------------------+
|dde93891-8a95-4e9...|
+--------------------+
scala> sql("select uuid()").explain()
== Physical Plan ==
*(1) Project [uuid(Some(4613707233104825008)) AS uuid()#23]
+- *(1) Scan OneRowRelation[]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
