dongjoon-hyun commented on a change in pull request #28392:
URL: https://github.com/apache/spark/pull/28392#discussion_r416810632
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/randomExpressions.scala
##########
@@ -145,6 +156,11 @@ case class Randn(child: Expression) extends RDG with
ExpressionWithRandomSeed {
}
override def freshCopy(): Randn = Randn(child)
+
+ override def flatArguments: Iterator[Any] = Iterator(child)
+ override def sql: String = {
+ s"randn(${if (useRandSeed) "" else child.sql})"
Review comment:
Currently, `Randn(child = expr, useRandSeed = true)` seems to be
possible in program. It might look weird because it will not use rand seed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
