cloud-fan commented on a change in pull request #26624: URL: https://github.com/apache/spark/pull/26624#discussion_r420666145
########## File path: core/src/main/scala/org/apache/spark/util/ThreadUtils.scala ########## @@ -157,23 +259,23 @@ private[spark] object ThreadUtils { */ def newDaemonFixedThreadPool(nThreads: Int, prefix: String): ThreadPoolExecutor = { val threadFactory = namedThreadFactory(prefix) - Executors.newFixedThreadPool(nThreads, threadFactory).asInstanceOf[ThreadPoolExecutor] + MDCAwareThreadPoolExecutor.newFixedThreadPool(nThreads, threadFactory) Review comment: Do you use open source Spark or your own fork? It's hard to convince the reviewers that the change is necessary, without clearly pointing out where we create these thread pools at executor side. Can you investigate further? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org