cloud-fan commented on a change in pull request #26624:
URL: https://github.com/apache/spark/pull/26624#discussion_r422975053
##########
File path: core/src/main/scala/org/apache/spark/util/ThreadUtils.scala
##########
@@ -130,7 +224,15 @@ private[spark] object ThreadUtils {
*/
def newDaemonCachedThreadPool(prefix: String): ThreadPoolExecutor = {
Review comment:
Let's make sure we are on the same page. What we document is:
1. users can set MDC properties via
`spark.sparkContext.setLocalProperty("mdc." + name, "value")`
2. Spark framework will send the local properties to the executor side and
set as task properties
3. We get the MDC properties from the task properties and apply them via
`MDC.put`, in `Executor.run`
We don't need to propagate MDC properties through thread pools at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
