cloud-fan commented on a change in pull request #26624: URL: https://github.com/apache/spark/pull/26624#discussion_r427024406
########## File path: core/src/main/scala/org/apache/spark/util/ThreadUtils.scala ########## @@ -133,6 +133,14 @@ private[spark] object ThreadUtils { Executors.newCachedThreadPool(threadFactory).asInstanceOf[ThreadPoolExecutor] } + /** + * Wrapper over newCachedThreadPool. Thread names are formatted as prefix-ID, where ID is a Review comment: This doesn't really have a prefix in the name. Can we inline this method? It's only called once. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org