cloud-fan commented on a change in pull request #28645:
URL: https://github.com/apache/spark/pull/28645#discussion_r442169198
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
##########
@@ -103,17 +102,19 @@ case class ScalaUDF(
}
}
- private def createToScalaConverter(i: Int, dataType: DataType): Any => Any =
{
- if (inputEncoders.isEmpty) {
- // for untyped Scala UDF
- CatalystTypeConverters.createToScalaConverter(dataType)
+ private def scalaConverter(i: Int, dataType: DataType): Any => Any = {
Review comment:
can we keep the name unchanged? If we keep using
`createToScalaConverter`, many diff can be avoided.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
