cloud-fan commented on a change in pull request #28645:
URL: https://github.com/apache/spark/pull/28645#discussion_r442171478
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
##########
@@ -1064,14 +1065,32 @@ case class ScalaUDF(
val (funcArgs, initArgs) =
evals.zipWithIndex.zip(children.map(_.dataType)).map {
case ((eval, i), dt) =>
val argTerm = ctx.freshName("arg")
- val initArg = if (CatalystTypeConverters.isPrimitive(dt)) {
+ // Check `inputPrimitives` when it's not empty in order to figure out
the Option
+ // type as non primitive type, e.g., Option[Int]. Fall back to
`isPrimitive` when
+ // `inputPrimitives` is empty for other cases, e.g., Java UDF, untyped
Scala UDF
Review comment:
so untyped Scala UDF doesn't support `Option`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
