TJX2014 commented on a change in pull request #28856:
URL: https://github.com/apache/spark/pull/28856#discussion_r443643942
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -2623,8 +2623,16 @@ object Sequence {
// about a month length in days and a day length in microseconds
val intervalStepInMicros =
stepMicros + stepMonths * microsPerMonth + stepDays * microsPerDay
- val startMicros: Long = num.toLong(start) * scale
- val stopMicros: Long = num.toLong(stop) * scale
+
+ // Date to timestamp is not equal from GMT and Chicago timezones
+ val (startMicros, stopMicros) = if (scale == 1) {
+ (num.toLong(start), num.toLong(stop))
+ }
+ else {
+ (daysToMicros(num.toInt(start), zoneId),
+ daysToMicros(num.toInt(stop), zoneId))
Review comment:
Done, maybe we can pass the scale through constructor：
private class TemporalSequenceImpl[T: ClassTag]
(dt: IntegralType, **scale: Long**, fromLong: Long => T, zoneId:
ZoneId)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
