Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5142#discussion_r27005643
  
    --- Diff: graphx/src/main/scala/org/apache/spark/graphx/VertexRDD.scala ---
    @@ -154,7 +154,30 @@ abstract class VertexRDD[VD](
        * @return a VertexRDD containing the results of `f`
        */
       def leftZipJoin[VD2: ClassTag, VD3: ClassTag]
    -      (other: VertexRDD[VD2])(f: (VertexId, VD, Option[VD2]) => VD3): 
VertexRDD[VD3]
    +      (other: VertexRDD[VD2])
    +      (f: (VertexId, VD, Option[VD2]) => VD3)
    +    : VertexRDD[VD3]
    +
    +  /**
    +   * Left joins this RDD with another VertexRDD with the same index. This 
function will fail if
    +   * both VertexRDDs do not share the same index. The resulting vertex set 
contains an entry for
    --- End diff --
    
    Is "will fail" correct? In the implementation, I think the codes fail back 
to creating same indices. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to