Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/5142#discussion_r27005945
--- Diff:
graphx/src/main/scala/org/apache/spark/graphx/impl/VertexPartitionBaseOps.scala
---
@@ -136,6 +136,31 @@ private[graphx] abstract class VertexPartitionBaseOps
leftJoin(createUsingIndex(other))(f)
}
+ def leftJoinWithFold[VD2: ClassTag, VD3: ClassTag, A]
+ (other: Self[VD2], acc: A)
--- End diff --
Reduce-style aggregation is named 'leftJoin', and fold-style aggregation is
'leftJoinWithFold'.
A rule of naming is kind of inconsistent, so would it be better to rename
'leftJoin' into 'leftJoinWithReduce'? Thought?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
