Sudhar287 commented on a change in pull request #29008:
URL: https://github.com/apache/spark/pull/29008#discussion_r450367396
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/RebaseDateTime.scala
##########
@@ -186,7 +186,7 @@ object RebaseDateTime {
.setTimeZone(TimeZoneUTC)
.setDate(localDate.getYear, localDate.getMonthValue - 1,
localDate.getDayOfMonth)
.build()
- Math.toIntExact(Math.floorDiv(utcCal.getTimeInMillis, MILLIS_PER_DAY))
+ Math.toIntExact(utcCal.getTimeInMillis, MILLIS_PER_DAY)
Review comment:
Oops Sorry, silly me.
And yes @srowen, this does make things faster. I can do some benchmarking if
you would like me to...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
