srowen commented on a change in pull request #29008: URL: https://github.com/apache/spark/pull/29008#discussion_r450369033
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/RebaseDateTime.scala ########## @@ -186,7 +186,7 @@ object RebaseDateTime { .setTimeZone(TimeZoneUTC) .setDate(localDate.getYear, localDate.getMonthValue - 1, localDate.getDayOfMonth) .build() - Math.toIntExact(Math.floorDiv(utcCal.getTimeInMillis, MILLIS_PER_DAY)) + Math.toIntExact(utcCal.getTimeInMillis, MILLIS_PER_DAY) Review comment: I guess I'd be surprised if the operations were meaningfully faster, given how much else is happening. I'm sure a microbenchmark of a trillion calls would show a difference, but that's not quite the use case. Nevertheless are there other instances where both args are definitely nonnegative? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org