AngersZhuuuu commented on a change in pull request #29035:
URL: https://github.com/apache/spark/pull/29035#discussion_r452576902
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/EliminateResolvedHint.scala
##########
@@ -43,6 +43,22 @@ object EliminateResolvedHint extends Rule[LogicalPlan] {
case h: ResolvedHint =>
hintErrorHandler.joinNotFoundForJoinHint(h.hints)
h.child
+ case join: Join if join.condition.isDefined =>
+ join.copy(
+ hint = join.hint.copy(
+ leftHint = removeCartesianProductJoinHint(join.hint.leftHint),
+ rightHint = removeCartesianProductJoinHint(join.hint.rightHint)))
+ }
+ }
+
+ def removeCartesianProductJoinHint(hint: Option[HintInfo]): Option[HintInfo]
= {
Review comment:
> I think we should pass a correct condition (`leftKeys` and
`rightKeys`) into `CartesianProductExec` instead of removing the hint:
>
https://github.com/apache/spark/blob/ac6406e7571027ba61193452d7a54f7895d2cbdc/sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala#L202
Yea, in default Cartesian Product Join situation, it didn't need condition
at all. So in default, it seems don't have condition when build data.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
