AngersZhuuuu commented on a change in pull request #29035:
URL: https://github.com/apache/spark/pull/29035#discussion_r453473254
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala
##########
@@ -199,7 +199,7 @@ abstract class SparkStrategies extends
QueryPlanner[SparkPlan] {
def createCartesianProduct() = {
if (joinType.isInstanceOf[InnerLike]) {
- Some(Seq(joins.CartesianProductExec(planLater(left),
planLater(right), condition)))
+ Some(Seq(joins.CartesianProductExec(planLater(left),
planLater(right), p.condition)))
Review comment:
> We need to write a comment above this line and explain what it is
doing.
> // instead of using the condition extracted by ExtractEquiJoinKeys, we
should use the original join condition, i.e., "p.condition".
Raise a PR https://github.com/apache/spark/pull/29084
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
