HyukjinKwon commented on a change in pull request #29122:
URL: https://github.com/apache/spark/pull/29122#discussion_r454883752
##########
File path: python/pyspark/sql/functions.py
##########
@@ -2392,7 +2393,7 @@ def json_tuple(col, *fields):
@since(2.1)
-def from_json(col, schema, options={}):
+def from_json(col, schema, options: Dict = None):
Review comment:
I am happy with trying Python type hints. Actually, I am thinking about
somehow leveraging (or porting?) https://github.com/zero323/pyspark-stubs, cc
@zero323. Let's avoid to introduce the type hinting in the main source for now
because we could decouple and run it separately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
