Fokko commented on a change in pull request #29122: URL: https://github.com/apache/spark/pull/29122#discussion_r454886119
########## File path: python/pyspark/sql/functions.py ########## @@ -2392,7 +2393,7 @@ def json_tuple(col, *fields): @since(2.1) -def from_json(col, schema, options={}): +def from_json(col, schema, options: Dict = None): Review comment: While touching the lines anyway, I thought is would be a nice addition. Having it in the source also makes live easier for the developers that work on pyspark itself. Furthermore, it is easier to keep the code and annotations in sync. Curious what Maciej thinks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org