agrawaldevesh commented on a change in pull request #29032: URL: https://github.com/apache/spark/pull/29032#discussion_r456023348
########## File path: core/src/main/scala/org/apache/spark/scheduler/TaskScheduler.scala ########## @@ -101,7 +101,8 @@ private[spark] trait TaskScheduler { /** * Process a decommissioning executor. */ - def executorDecommission(executorId: String): Unit + def executorDecommission( Review comment: Okay. Was just trying to avoid changing a bunch of mock/test implementations of this interface. Will revert back to having this be purely abstract. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org