leanken commented on a change in pull request #29104:
URL: https://github.com/apache/spark/pull/29104#discussion_r457813266
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala
##########
@@ -64,10 +65,32 @@ case class BroadcastHashJoinExec(
val numOutputRows = longMetric("numOutputRows")
val broadcastRelation = buildPlan.executeBroadcast[HashedRelation]()
- streamedPlan.execute().mapPartitions { streamedIter =>
- val hashed = broadcastRelation.value.asReadOnlyCopy()
-
TaskContext.get().taskMetrics().incPeakExecutionMemory(hashed.estimatedSize)
- join(streamedIter, hashed, numOutputRows)
+ if (isNullAwareAntiJoin) {
+ streamedPlan.execute().mapPartitionsInternal { streamedIter =>
+ if (broadcastRelation.value.inputEmpty) {
+ streamedIter
+ } else if (broadcastRelation.value.anyNullKeyExists) {
Review comment:
> We can also expand this optimization to shuffle hash join as well (we
don't have to include it in this PR).
Sure.
I can do some research to see if i can support shuffled hash join and multi
column support in next PR, maybe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
