holdenk edited a comment on pull request #29180: URL: https://github.com/apache/spark/pull/29180#issuecomment-663313791
> @holdenk, I think there is a bit of differences between Scala/Java and Python. For example, Python type hinting is optional and still premature. Optional yes. Why do you believe it is premature? The PEP is 6 years old ( https://www.python.org/dev/peps/pep-0484/ ). I did an informal survey once we decided to drop old versions of Python and supporting typing seems fairly popular ( https://twitter.com/holdenkarau/status/1282486803249762304 ). We could do a survey with users@ if you don't think this feature would be impactful. > > We could think about adding the type hints into the code but maybe we should port it first (or have a separate repo) and see how it goes to the end-users. Also, porting/managing stub files separately is much easier than fixing them in the codes in place. It will take a low risk and same output. For example, fixing the codes will likely bring some mistakes. As a bonus, that will likely keep the author as @zero323 easily as it will be ported as is ideally in one PR. If folks are against in-line types in the Python code I suppose porting the hints file is an OK compromise. I'd rather have them in-line as a developer but, if our options are no types or having it live in a separate file I'll take the second one. How should we best keep the type hints up to date if it's in a seperate file? Could we add something to the PR templated for Python requests? As for a separate repo what do you envision? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
