HyukjinKwon edited a comment on pull request #29180: URL: https://github.com/apache/spark/pull/29180#issuecomment-663316562
It is getting popular and more stable but the typing hint is still being evolved even between the minor versions. See https://docs.python.org/3/library/typing.html. One example might be [PEP 544](https://www.python.org/dev/peps/pep-0544/) that allows structural subtyping (Python 3.8). It could change the fundamental way of how we type. I don't strongly object to have the codes inlined but I would think it's more safer and easier way to port the files first. > How should we best keep the type hints up to date if it's in a seperate file? > Could we add something to the PR templated for Python requests? > As for a separate repo what do you envision? I am sure we will figure a way out. For example, - We could take NumPy approach e.g. [numpy/__init__.pyi](https://github.com/numpy/numpy/blob/master/numpy/__init__.pyi). - Or we can port his repo to ASF (is it feasible?). I think IDE can detect. If I am not mistaken, mypy can detect too as a linter. If dev people fine it confusing, we should maybe document it in PR template as you suggest or in the contribution guide. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
