imback82 commented on a change in pull request #29328:
URL: https://github.com/apache/spark/pull/29328#discussion_r466824972



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala
##########
@@ -229,7 +229,7 @@ class DataFrameReader private[sql](sparkSession: 
SparkSession) extends Logging {
    */
   def load(path: String): DataFrame = {
     // force invocation of `load(...varargs...)`
-    option("path", path).load(Seq.empty: _*)

Review comment:
       Sorry, I didn't get the suggestion. Are you suggesting not to check if 
the option already exists?  Then we still have to go 
[this](https://github.com/apache/spark/pull/29328/commits/63f3d60b0b00990cd5a2784b1be8961c058dc2c6#diff-f70bda59304588cc3abfa3a9840653f4R248)
 route where `paths` parameter is also updated, right? (The root cause of the 
inconsistency is that if you call `parquet(path)`, it would go to `load(paths: 
String*)` instead of `load(path: String)`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to