[GitHub] [spark] imback82 commented on a change in pull request #29328: [SPARK-32516][SQL] 'path' option cannot co-exist with load()'s path parameters

[GitBox]

imback82 commented on a change in pull request #29328:
URL: https://github.com/apache/spark/pull/29328#discussion_r468168199



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala
##########
@@ -245,6 +246,10 @@ class DataFrameReader private[sql](sparkSession: 
SparkSession) extends Logging {
         "read files of Hive data source directly.")
     }
 

Review comment:
       Removing `def load(path: String)` breaks the binary compatibility:
   ```Exception in thread "main" java.lang.NoSuchMethodError: 
org.apache.spark.sql.DataFrameReader.load(Ljava/lang/String;)Lorg/apache/spark/sql/Dataset;```
   So, I will not remove it.
   
   Also, is the following required?
   > else if (paths.length == 1) {
   >       Some("path" -> paths.head)
   >     }
   
   I see `paths` should handle one or more paths: 
https://github.com/apache/spark/blob/8659ec554fe1993fcaf2ec4d1c4745205bddec7d/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FileDataSourceV2.scala#L51-L57
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org