cloud-fan commented on a change in pull request #29349:
URL: https://github.com/apache/spark/pull/29349#discussion_r466840338
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/JoinReorderSuite.scala
##########
@@ -307,9 +307,9 @@ class JoinReorderSuite extends PlanTest with
StatsEstimationTestBase {
val originalPlan2 =
t1.join(t2, Inner, Some(nameToAttr("t1.k-1-2") ===
nameToAttr("t2.k-1-5")))
.hint("broadcast")
- .join(t4, Inner, Some(nameToAttr("t4.v-1-10") ===
nameToAttr("t3.v-1-100")))
+ .join(t4, Inner, Some(nameToAttr("t1.k-1-2") ===
nameToAttr("t4.k-1-2")))
Review comment:
the join condition was wrong written. `t3` is not accessible here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
