cloud-fan commented on a change in pull request #29349:
URL: https://github.com/apache/spark/pull/29349#discussion_r466840696
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/SimplifyCastsSuite.scala
##########
@@ -42,7 +42,8 @@ class SimplifyCastsSuite extends PlanTest {
test("nullable element to non-nullable element array cast") {
val input = LocalRelation('a.array(ArrayType(IntegerType, true)))
- val plan = input.select('a.cast(ArrayType(IntegerType,
false)).as("casted")).analyze
+ val attr = input.output.head
+ val plan = input.select(attr.cast(ArrayType(IntegerType,
false)).as("casted"))
Review comment:
here we are testing something that can't pass analysis, just to make
sure the optimizer rule is robust.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
