dongjoon-hyun commented on a change in pull request #29378:
URL: https://github.com/apache/spark/pull/29378#discussion_r467641518
##########
File path: core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala
##########
@@ -46,18 +46,36 @@ private[spark] class DiskBlockManager(conf: SparkConf,
deleteFilesOnStop: Boolea
System.exit(ExecutorExitCode.DISK_STORE_FAILED_TO_CREATE_DIR)
}
+ def containerDirEnabled: Boolean = Utils.isRunningInYarnContainer(conf)
+
+ /* Create container directories on YARN to persist the temporary files.
+ * (temp_local, temp_shuffle)
+ * These files have no opportunity to be cleaned before application end on
YARN.
+ * This is a real issue, especially for long-lived Spark application like
Spark thrift-server.
+ * So we persist these files in YARN container directories which could be
cleaned by YARN when
+ * the container exists. */
Review comment:
nit. Could you adjust into Javadoc style?
- https://github.com/databricks/scala-style-guide#documentation-style
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
