dongjoon-hyun commented on a change in pull request #29378: URL: https://github.com/apache/spark/pull/29378#discussion_r467640938
########## File path: core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala ########## @@ -81,17 +99,29 @@ private[spark] class DiskBlockManager(conf: SparkConf, deleteFilesOnStop: Boolea new File(subDir, filename) } - def getFile(blockId: BlockId): File = getFile(blockId.name) Review comment: Hi, @LantaoJin . Why does this PR need to remove this function signature? Can we keep this function signature to minimize this PR's surface? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org