cloud-fan commented on a change in pull request #29328:
URL: https://github.com/apache/spark/pull/29328#discussion_r468326123
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala
##########
@@ -395,7 +395,7 @@ class DataFrameReaderWriterSuite extends QueryTest with
SharedSparkSession with
.load("/test")
assert(LastOptions.parameters("intOpt") == "56")
- assert(LastOptions.parameters("path") == "/test")
+ assert(!LastOptions.parameters.contains("path"))
Review comment:
Sorry I missed one thing. For DS v1, `...load(path)` will generate a
`path` option, which is visible to v1 sources, and we can't break it. It's
strange that `...load(path1, path2)` will completely ignore the paths and don't
pass paths to v1 sources, but there is nothing we can do here.
We need to update `DataFrameReader.loadV1Source` to generate a `path` option
if `paths.length == 1` (and set paths to Nil), to keep the previous behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
